-
Notifications
You must be signed in to change notification settings - Fork 617
Add AuthCtx to ReducerContext for rust #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there were also stuff from my previous review that was not addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some improvements atop of this PR, primarily wrt. docs, but this looks good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'm a code-owner of anything touched by this PR anymore, but it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off on my code-owned files under crates/cli
. Afaict they're unrelated cleanups, but innocuous enough.
Description of Changes
This exposes client credentials in reducer calls for rust.
API and ABI breaking changes
API Changes:
The main API change is the addition of
AuthCtx
and thesender_auth
inReducerContext
. This also adds JwtClaims, which has some helpers for getting commonly used claims.ABI Changes:
This adds one new functions
get_jwt
. This usesst_connection_credentials
to look up the credentials associated with a connection id.This adds ABI version 10.2.
Expected complexity level and risk
Testing
I've done some manual testing with modified versions of the quickstart. We should add some examples that use the new API.